Broadcasting or-or incurs allocations

[charleskawczynski]

MWE:

using Revise, Test
import ClimaCore
if !(@isdefined TU)
    include(joinpath(pkgdir(ClimaCore), "test", "TestUtilities", "TestUtilities.jl"))
    import .TestUtilities as TU
end
foo(a, c) = a;
FT_broadcast_allocating!(a) = FT_broadcast_allocating!(a, eltype(a));
function FT_broadcast_allocating!(a, ::Type{FT}) where FT
    @. a = foo(a, false || a < FT(1))
    # @. a = foo(a, a < FT(1)) # unexpected pass
    return nothing
end;
space = TU.CenterExtrudedFiniteDifferenceSpace(Float32);
a = ClimaCore.Fields.level(fill(Float32(0), space), 1);

FT_broadcast_allocating!(a) # compile first

p_allocated = @allocated FT_broadcast_allocating!(a)
@test_broken p_allocated == 0

[simonbyrne]

Does broadcasting over || actually work?

[charleskawczynski]

Does broadcasting over || actually work?

It at least doesn't break

[charleskawczynski]

This is an upstream issue: JuliaLang/julia#50554

[charleskawczynski]

This is now fixed in Julia 1.10