Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We should copy colors from the user’s color theme into ImGui’s theme #75699

Closed
db48x opened this issue Aug 15, 2024 · 1 comment · Fixed by #77842
Closed

We should copy colors from the user’s color theme into ImGui’s theme #75699

db48x opened this issue Aug 15, 2024 · 1 comment · Fixed by #77842
Labels
ImGui Anything related to the new ImGui UI for SDL/tiles or ImTui for curses builds (P4 - Low) Low priority issues: things which are e.g exotic, minor and/or hard to encounter <Suggestion / Discussion> Talk it out before implementing

Comments

@db48x
Copy link
Contributor

db48x commented Aug 15, 2024

Is your feature request related to a problem? Please describe.

ImGui has it’s own theme from which it draws colors, but it isn’t linked in any way to the user’s preferred colors.

Solution you would like.

When ImGui uses a color, let's say blue, we should pull the corresponding color from the user’s color theme.

Describe alternatives you have considered.

One alternative is to let the user provide their own ImGui theme. However, this is much more complicated and is not really needed in the short term.

Additional context

No response

@db48x db48x added the <Suggestion / Discussion> Talk it out before implementing label Aug 15, 2024
@sonphantrung
Copy link
Contributor

Speaking of theming, there's also this function for rendering fonts like in SDL/Text interface, yet I don't see it being used anywhere, so it uses the default font

@GuardianDll GuardianDll added (P4 - Low) Low priority issues: things which are e.g exotic, minor and/or hard to encounter ImGui Anything related to the new ImGui UI for SDL/tiles or ImTui for curses builds labels Aug 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ImGui Anything related to the new ImGui UI for SDL/tiles or ImTui for curses builds (P4 - Low) Low priority issues: things which are e.g exotic, minor and/or hard to encounter <Suggestion / Discussion> Talk it out before implementing
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants