Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The debug menu has a funny size #75667

Open
db48x opened this issue Aug 14, 2024 · 8 comments · May be fixed by #77867
Open

The debug menu has a funny size #75667

db48x opened this issue Aug 14, 2024 · 8 comments · May be fixed by #77867
Labels
ImGui Anything related to the new ImGui UI for SDL/tiles or ImTui for curses builds (S2 - Confirmed) Bug that's been confirmed to exist

Comments

@db48x
Copy link
Contributor

db48x commented Aug 14, 2024

Describe the bug

The primary debug menu has a lot of text at the top that causes problems when the code tries to pick a correct size for the menu. Currently it overrides the default sizing and sets itself to half the width and height of the screen. This looks awkward on normal screens but not half so awkward as it would otherwise. It looks even worse on small screens.

Attach save file

n/a

Steps to reproduce

Open the debug menu, you can’t miss it.

Expected behavior

I expect it to look so normal and ordinary that you don’t even notice it.

Screenshots

Screenshot 2024-08-14 at 10-38-56 uilist issues from migration #74341 · Issue #75661 · CleverRaven_Cataclysm-DDA

Small window:
Screenshot 2024-08-14 at 10-44-35 uilist issues from migration #74341 · Issue #75661 · CleverRaven_Cataclysm-DDA

Versions and configuration

  • OS: Linux
    • OS Version:
  • Game Version: ad2c7ed-dirty [64-bit]
  • Graphics Version: Tiles
  • Game Language: System language []
  • Mods loaded: [
    Dark Days Ahead [dda],
    Magiclysm [magiclysm],
    Disable NPC Needs [no_npc_food],
    Portal Storms Ignore NPCs [personal_portal_storms],
    Slowdown Fungal Growth [no_fungal_growth]
    ]

Additional context

No response

@db48x db48x added the (S1 - Need confirmation) Report waiting on confirmation of reproducibility label Aug 14, 2024
@GuardianDll GuardianDll added (S2 - Confirmed) Bug that's been confirmed to exist ImGui Anything related to the new ImGui UI for SDL/tiles or ImTui for curses builds and removed (S1 - Need confirmation) Report waiting on confirmation of reproducibility labels Aug 14, 2024
@ZhilkinSerg
Copy link
Contributor

Removing debug.desired_bounds = { -1.0, -1.0, 0.5, 0.5 }; makes it look okayish:

image

@ZhilkinSerg
Copy link
Contributor

Additionally removing flavor text makes it look nice:

image

@db48x
Copy link
Contributor Author

db48x commented Aug 14, 2024

Removing the override on the bounds is a simple enough patch. How does it look when the game window is small?

I don’t think we should remove the text; it does serve a purpose, and its removed automatically if you have a debug character. But maybe the first part, “Debug Functions”, should be a title instead. Then the text can be slightly shorter.

@ZhilkinSerg
Copy link
Contributor

There is strange blue border appearing on third(?) key input, but it seems to affect all menus:

image

@db48x
Copy link
Contributor Author

db48x commented Aug 14, 2024

That’s known, not really that strange, happens when you wrap around from top to bottom or bottom to top, and is a separate issue.

@ZhilkinSerg
Copy link
Contributor

image

image

@db48x
Copy link
Contributor Author

db48x commented Aug 14, 2024

Looks ok there, but what about a tall narrow window like a phone in portrait mode? Like in the original post.

@CLIDragon
Copy link
Contributor

For reference, this is what it used to look like on a normal sized screen:
image

And on a portrait mode screen:
image

Same dimensions, just locked larger I suspect.

@ZhilkinSerg ZhilkinSerg linked a pull request Nov 15, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ImGui Anything related to the new ImGui UI for SDL/tiles or ImTui for curses builds (S2 - Confirmed) Bug that's been confirmed to exist
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants