Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Android builds failing #64293

Closed
Termineitor244 opened this issue Mar 16, 2023 · 2 comments · Fixed by #64305
Closed

Android builds failing #64293

Termineitor244 opened this issue Mar 16, 2023 · 2 comments · Fixed by #64305
Labels
Code: Build Issues regarding different builds and build environments OS: Android Issues related to Android operating system OS: macOS Issues related to macOS / OSX operating system

Comments

@Termineitor244
Copy link
Contributor

Describe the bug

The Android Builds for the newest experimental versions of the game are failing to generate after #64152 was merged.

Attach save file

N/A

Steps to reproduce

Look at the experimental builds after the PR in question was merged.

Expected behavior

To have experimental builds for android generating correctly.

Screenshots

No response

Versions and configuration

N/A

Additional context

No response
@Termineitor244 Termineitor244 added the (S1 - Need confirmation) Report waiting on confirmation of reproducibility label Mar 16, 2023
@anothersimulacrum
Copy link
Member

anothersimulacrum commented Mar 16, 2023 •
edited
Loading

CC @jbytheway

OSX is failing too: https://github.com/CleverRaven/Cataclysm-DDA/actions/runs/4437676544/jobs/7789080345#step:16:137

Android seems to not be compiling with C++17: https://github.com/CleverRaven/Cataclysm-DDA/actions/runs/4437676544/jobs/7789081151#step:19:3462

@anothersimulacrum anothersimulacrum added Code: Build Issues regarding different builds and build environments OS: Android Issues related to Android operating system OS: macOS Issues related to macOS / OSX operating system and removed (S1 - Need confirmation) Report waiting on confirmation of reproducibility labels Mar 16, 2023
@BrettDong BrettDong mentioned this issue Mar 16, 2023
Merged
@jbytheway
Copy link
Contributor

OSX is failing too: https://github.com/CleverRaven/Cataclysm-DDA/actions/runs/4437676544/jobs/7789080345#step:16:137

I've opened #64314 to fix the OS X build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Code: Build Issues regarding different builds and build environments OS: Android Issues related to Android operating system OS: macOS Issues related to macOS / OSX operating system
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Build Android in C++17 mode BrettDong/Cataclysm-DDA
3 participants
@jbytheway @anothersimulacrum @Termineitor244