Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors / Test Failures to catch problems in disassembly code #64009

Closed
Karol1223 opened this issue Mar 6, 2023 · 1 comment
Closed

Errors / Test Failures to catch problems in disassembly code #64009

Karol1223 opened this issue Mar 6, 2023 · 1 comment
Labels
stale Closed for lack of activity, but still valid. <Suggestion / Discussion> Talk it out before implementing

Comments

@Karol1223
Copy link
Contributor

Karol1223 commented Mar 6, 2023

Is your feature request related to a problem? Please describe.

uncraft recipes can use lists for ingredients and... they don't work. That is, they do work - by all means, they throw no error or test failure - but the recipe cannot utilize a list. Uncrafts can only read the first-written component from that list and will always use that one. This is a problem because in case of typos with not enough brackets in the components section sometimes lists are accidentally created and the uncraft will not function as intended while also not notifying anyone that something is wrong.
Some examples of PRs fixing these include: #64005 and #63024
These mistakes have been made by at least 3 contributors that I've observed, myself included - which I followed to duplicate these mistakes in following PRs by copying my own broken code.

Solution you would like.

A test failure or a game error mentioning the use of a list in an uncraft recipe - uncrafts cannot use lists anyway.

Describe alternatives you have considered.

No response

Additional context

Brownie points for if there's also an Error / Test Failure for when:

  • an item has two uncrafts defined
  • an item has an uncraft and a reversible recipe defined

The reason being disassemblies cannot utilize multiple uncrafts either. If there are two uncrafts or an uncraft and a reversible present, the game will always use the one first read by it and pretend the other one doesn't exist.

@Karol1223 Karol1223 added the <Suggestion / Discussion> Talk it out before implementing label Mar 6, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Apr 5, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not bump or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

@github-actions github-actions bot added the stale Closed for lack of activity, but still valid. label Apr 5, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Closed for lack of activity, but still valid. <Suggestion / Discussion> Talk it out before implementing
Projects
None yet
Development

No branches or pull requests

1 participant