Errors / Test Failures to catch problems in disassembly code #64009
Labels
stale
Closed for lack of activity, but still valid.
<Suggestion / Discussion>
Talk it out before implementing
Is your feature request related to a problem? Please describe.
uncraft
recipes can use lists for ingredients and... they don't work. That is, they do work - by all means, they throw no error or test failure - but the recipe cannot utilize a list. Uncrafts can only read the first-written component from that list and will always use that one. This is a problem because in case of typos with not enough brackets in thecomponents
section sometimes lists are accidentally created and the uncraft will not function as intended while also not notifying anyone that something is wrong.Some examples of PRs fixing these include: #64005 and #63024
These mistakes have been made by at least 3 contributors that I've observed, myself included - which I followed to duplicate these mistakes in following PRs by copying my own broken code.
Solution you would like.
A test failure or a game error mentioning the use of a list in an uncraft recipe - uncrafts cannot use lists anyway.
Describe alternatives you have considered.
No response
Additional context
Brownie points for if there's also an Error / Test Failure for when:
The reason being disassemblies cannot utilize multiple uncrafts either. If there are two uncrafts or an uncraft and a reversible present, the game will always use the one first read by it and pretend the other one doesn't exist.
The text was updated successfully, but these errors were encountered: