Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Radiation badges aren't supposed to reset. But in the game they do, sorta. #63283

Closed
dom4op opened this issue Jan 25, 2023 · 1 comment · Fixed by #63395
Closed

Radiation badges aren't supposed to reset. But in the game they do, sorta. #63283

dom4op opened this issue Jan 25, 2023 · 1 comment · Fixed by #63395
Labels
(S1 - Need confirmation) Report waiting on confirmation of reproducibility

Comments

@dom4op
Copy link

dom4op commented Jan 25, 2023

Describe the bug

Some sidebars (custom, labels, labels narrow, thick and probably others I forgot) have a "Radiation" field. If you put on a radiation badge, this field shows the color of its film strip, which is very convenient.

However, the radiation badge isn't supposed to reset. If it was a brand new green-colored badge and you got a dose of radiation, it will turn yellow and stay yellow, unless you get even more radiation and it will go red/black. Bottom line, it will never become green again.

In the game, radiation badge (the item) doesn't reset. But the sidebar color does.

Here is my character's radiation badge - you can see it says "orange" at the bottom.

image

The rad exposure happened some time ago, and after a lot of sleep, water and Prussian blue tablets some of that radiation went away. The badge still says "orange", but the sidebar says "blue"

image

Tested it on several other sidebar layouts - everything that has "Radiation" field works the same. They don't show the badge's film stip color - they show your current radiation level instead.

Steps to reproduce

  1. Put on a radiation badge
  2. Bathe in radiation until it changes colour
  3. Walk away from the source of radiation and eat a dozen Prussian blue tablets
  4. Watch how your sidebar "Radiation" field changes colour to less severe (yellow, then blue, then green) while your badge's colour remains orange/red/black

Expected behavior

I expect the sidebar Radiation field to show the current colour of the badge

Screenshots

No response

Versions and configuration

OS: Windows
OS Version: 10.0.22000.1455 (21H2)
Game Version: 0808fe7 [64-bit]
Graphics Version: Tiles
Game Language: English [en]
Mods loaded: [
Dark Days Ahead [dda],
Disable NPC Needs [no_npc_food],
Portal Storms Ignore NPCs [personal_portal_storms],
No Fungal Growth [no_fungal_growth],
Bionic Slots [cbm_slots]
]

Additional context

No response

@dom4op dom4op added the (S1 - Need confirmation) Report waiting on confirmation of reproducibility label Jan 25, 2023
@cake-pie
Copy link
Contributor

cake-pie commented Feb 1, 2023

This is a sidebar UI issue and not a problem with the badges. The sidebar widget was jsonized in #55079 and from comments there it was known that the implementation had some flaws:

I can see that it would be complicated trying to get a stored item value like radiation out of an NPC talker condition...

Having the sidebar show personal radiation (but only while wearing the badge) may be a little unrealistic, but probably more useful to the player.

I would guess there's a chance of a discrepancy between sidebar badge color and the displayed color on the description of the badge itself

Ping @dseguin for your attention, in case you haven't seen this yet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
(S1 - Need confirmation) Report waiting on confirmation of reproducibility
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants