Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fluids directly insertable into meta-container when not full #56856

Closed
Golfavel opened this issue Apr 16, 2022 · 0 comments · Fixed by #56863
Closed

Fluids directly insertable into meta-container when not full #56856

Golfavel opened this issue Apr 16, 2022 · 0 comments · Fixed by #56863
Labels
<Crash / Freeze> Fatal bug that results in hangs or crashes. Items: Containers Things that hold other things

Comments

@Golfavel
Copy link
Contributor

Describe the bug

Fluids inside of a container (eg, plastic bottle) that is not full will still show as insertable when manually inserting items into the highest level container (eg, backpack), and trying to insert them again crashes the game (no log)

Steps to reproduce

  1. Acquire a contained fluid that is neither full nor empty
  2. Insert the fluid and subsequently its container into another container (eg, a backpack or pants)
  3. Open the menu to manually insert items into said container ((i)nventory, highlight used container, (enter) for more item options, (i)nsert items manually)
  4. Insert the already contained fluid (not its container, which should not be visible from my tests) into the container
  5. Log-less Crash

Expected behavior

Fluids, particularly fluids already in the container, should be blacklisted from being (re)inserted

Screenshots

Screenshot_20220416_133453

Versions and configuration

  • OS: Linux
    • OS Version: Distributor ID: Ubuntu; Description: Ubuntu 20.04.4 LTS; Release: 20.04; Codename: focal;
  • Game Version: 5fe200b [64-bit]
  • Graphics Version: Tiles
  • Game Language: English [en]
  • Mods loaded: [
    Dark Days Ahead [dda],
    Disable NPC Needs [no_npc_food],
    No Fungal Growth [no_fungal_growth],
    Bionic Professions [package_bionic_professions]
    ]

Additional context

TESTING.zip
This world has the bare minimum on hand to quickly cause the crash.
No crash logs are created when this happens so none available to post here.

@dseguin dseguin added <Crash / Freeze> Fatal bug that results in hangs or crashes. Items: Containers Things that hold other things labels Apr 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Crash / Freeze> Fatal bug that results in hangs or crashes. Items: Containers Things that hold other things
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants