Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert hardcoded display text widgets to conditional clauses #55076

Open
13 of 14 tasks
wapcaplet opened this issue Feb 4, 2022 · 3 comments
Open
13 of 14 tasks

Convert hardcoded display text widgets to conditional clauses #55076

wapcaplet opened this issue Feb 4, 2022 · 3 comments
Assignees
Labels
[C++] Changes (can be) made in C++. Previously named `Code` Info / User Interface Game - player communication, menus, etc. [JSON] Changes (can be) made in JSON

Comments

@wapcaplet
Copy link
Contributor

wapcaplet commented Feb 4, 2022

Is your feature request related to a problem? Please describe.

Now that dseguin's incredibly awesome conditional clause widgets are merged (#54693), we can JSONize a bunch of the xx_text widget variables that were carried over from the old hard-coded sidebar panel system.

Solution you would like.

Replace these widget_var implementations with widgets using conditional "clauses":

Describe alternatives you have considered.

No response

Additional context

These widget_vars were already converted to conditional clauses in #54693:

  • bp_status_text
  • bp_status_sym_text
  • bp_status_legend_text
@wapcaplet wapcaplet added [C++] Changes (can be) made in C++. Previously named `Code` [JSON] Changes (can be) made in JSON Info / User Interface Game - player communication, menus, etc. labels Feb 4, 2022
@wapcaplet wapcaplet self-assigned this Feb 4, 2022
@wapcaplet
Copy link
Contributor Author

@dseguin I got started on (and almost finished) activity_text. Let me know if there are others you're working on, or want to work on.

@dseguin
Copy link
Member

dseguin commented Feb 5, 2022

Sure, I can take care of the movement mode indicators (move_mode_letter and move_mode_text).

@dseguin
Copy link
Member

dseguin commented Feb 14, 2022

@wapcaplet I went ahead and wrapped up these clauses:

All that's left is the weather widget :P

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[C++] Changes (can be) made in C++. Previously named `Code` Info / User Interface Game - player communication, menus, etc. [JSON] Changes (can be) made in JSON
Projects
None yet
Development

No branches or pull requests

2 participants