Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using Weapon Categories to define weapon specific techniques and buffs #52783

Closed
Termineitor244 opened this issue Nov 12, 2021 · 0 comments · Fixed by #52788
Closed

Using Weapon Categories to define weapon specific techniques and buffs #52783

Termineitor244 opened this issue Nov 12, 2021 · 0 comments · Fixed by #52788
Labels
<Enhancement / Feature> New features, or enhancements on existing Martial Arts Arts, Techniques, weapons and anything touching martial arts.

Comments

@Termineitor244
Copy link
Contributor

Is your feature request related to a problem? Please describe.

I was answering a comment talking about using weapon categories for unarmed weapons, and while thinking about the issue with these weapons (They already use a flag to determine if they are compatible with a style, adding a weapon category to them would need me to specify "melee_allowed": true, for the unarmed styles and some styles use different techniques for weapons and unarmed) made me realize that what they need to make use of the infrastructure of weapon categories is something that would greatly benefit all martial arts already in the game: use of weapon categories to determine if a tech or buff is usable.

Describe the solution you'd like

I will explain the concept:
In the same way that we can now easily determine with what weapons should a style work or not, we could determine if a specific technique or buff should work with a specific category of weapons.

Examples:
Lets say, Krav Maga using a special technique with batons to trip the opponent, but at the same time having a unique buff to critical chance while using knives because you will be fighting very close to the opponent and can more easily strike vital points.

For the current staff techniques and buffs of Karate, it would look something like this:

"onhit_buffs": [
      {
        "id": "buff_karate_onhit",
        "name": "Karate Kata",
        ......
        "unarmed_allowed": true,
        "weapon_category_allowed": "QUARTERSTAVES",
        ......
      }
    ]
  {
    "type": "technique",
    "id": "tec_karate_staff",
    "name": "Staff Strike",
    ........
    "weapon_category_allowed": "QUARTERSTAVES",
    .....
  }

Where "weapon_category_allowed": "QUARTERSTAVES" fills the role of "melee_allowed": true, but would allow for more granularity in the future.

You should be able to declare one or more weapon categories, so a technique can be used by, for example, short and medium swords, but not long swords.

Describe alternatives you've considered

To just allow weapons with the flag "UNARMED_WEAPON" to be displayed in the martial arts menu like the current weapons categories.

Additional context

This would allow to use unarmed techniques with certain weapons (The knuckles and cestus), which currently use a flag to be used, and allow these to be listed along the rest of the weapons of a style.

An imaginary style using this feature:

Name: 3 Ways
Weapon categories: Long Swords, Knives and Claws

Buffs:
Name: Persistence
Type: On hit buff
Effects: -10% move cost
Melee allowed (So it can be used by all the weapons in the style)

Name: Close Combat
Effects: +10% Critical hit chance
Weapon categories allowed: Knives and Claws

Techniques:
Name: Wide Slash
Effects: Wide technique, -10% damage
Weapon categories allowed: Long Swords

Name: Smash
Effects: Knockdown 2 turns -100% Cutting and Pierce Damage
Weapon categories allowed: Long Swords

Name: Vital Strike
Effects: +25% Damage
Weapon categories allowed: Knives and Claws

Etc...

@wapcaplet wapcaplet added <Enhancement / Feature> New features, or enhancements on existing Martial Arts Arts, Techniques, weapons and anything touching martial arts. labels Nov 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Enhancement / Feature> New features, or enhancements on existing Martial Arts Arts, Techniques, weapons and anything touching martial arts.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants