Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Krav Maga weaponry (Is a tanto a Krav weapon?) #48854

Closed
6maboc opened this issue May 13, 2021 · 1 comment · Fixed by #48877
Closed

Krav Maga weaponry (Is a tanto a Krav weapon?) #48854

6maboc opened this issue May 13, 2021 · 1 comment · Fixed by #48877
Labels
Items / Item Actions / Item Qualities Items and how they work and interact Mods: Magiclysm Anything to do with the Magiclysm mod

Comments

@6maboc
Copy link

6maboc commented May 13, 2021

Is your feature request related to a problem? Please describe.

As it currently stands, the tanto is not a valid Krav Maga weapon in default. Magiclysm also currently considers the Tanto+1 and Tanto+2 to be valid weapons.

Describe the solution you'd like

This can probably be remedied with a simple .json edit. However, I suspect that the valid weapons list may need additional changes (or not).

Describe alternatives you've considered

A more elegant solution (to me) would be to be enable white/blacklisting weapon groups through their flags, but I'm not sure if this is worth the effort to implement.

Additional context

Krav Maga, as it is currently implemented, seems to accept: batons/tonfas, knives, handguns, and rifles.
This could easily be a PR, but I wanted to ask around if there were any other potential irregularities in the weapons lists for other martial arts or Krav Maga itself.

@ZhilkinSerg
Copy link
Contributor

#33602

@Maleclypse Maleclypse added Items / Item Actions / Item Qualities Items and how they work and interact Mods: Magiclysm Anything to do with the Magiclysm mod labels May 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Items / Item Actions / Item Qualities Items and how they work and interact Mods: Magiclysm Anything to do with the Magiclysm mod
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants