You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
Trying to work with all JSON objects in the game together is unwieldy and uncomfortable. Fields can change type and meaning in different contexts and there is a general feeling of incoherence. It may not be an intended workflow, but for now tools/json_tools/util.py is implemented like this, trying to work with everything in data/json/ as a whole, and trying to improve it is frustrating.
Describe the solution you'd like
Using JSON Schemas to define a standard to strive for and gradually update existing JSON so that it matches the schemas.
Making sure that type and id together can identify any JSON object globally.
Renaming id to ids where it contains a list of values.
Using id instead of abstract field. (I'm not sure, is there a benefit to having this separate field?)
Renaming type to something like loader_type or deserializer_type to make it more comprehensible.
Ok, I'm closing this as the consensus between main developers is against these changes (see the linked Discord discussions).
But please add your voice arguments if you've found this issue after encountering similar problems.
Also looks like the consensus several months ago was against simplifying working with JSON not from C++ if it would entail any changes to workflows. I disagree and I'll stop trying to improve Python tools for now as it seems futile after reading these discussions.
Is your feature request related to a problem? Please describe.
Trying to work with all JSON objects in the game together is unwieldy and uncomfortable. Fields can change type and meaning in different contexts and there is a general feeling of incoherence. It may not be an intended workflow, but for now
tools/json_tools/util.py
is implemented like this, trying to work with everything indata/json/
as a whole, and trying to improve it is frustrating.Describe the solution you'd like
Using JSON Schemas to define a standard to strive for and gradually update existing JSON so that it matches the schemas.
Making sure that
type
andid
together can identify any JSON object globally.Renaming
id
toids
where it contains a list of values.Using
id
instead ofabstract
field. (I'm not sure, is there a benefit to having this separate field?)Renaming
type
to something likeloader_type
ordeserializer_type
to make it more comprehensible.Additional context
#42958
#42959
https://discordapp.com/channels/598523535169945603/598535827169083403/744539312674308138
#42984
I still have to read this #34735
The text was updated successfully, but these errors were encountered: