Previous game's NPC followers have "memory" of new player

[Ceepert]

Describe the bug
When you have a world that you keep once a character dies, npc´s you have met with your old/dead character talk to a new character, that they never met, like it is the old character.

To Reproduce
Steps to reproduce the behavior:

1. Create World + Character (make world settings to keep world on death + idealy set spawning npc to always)
2. Get the NPC to follow you, or get a quest.
3. Die/Make a new character in the same world.
4. If you got the NPC to follow you he will, at some point, appear next to the new character, still following you, even though the NPC technicaly has no Idea who you are. (He also still has the same active quests and relationship with you)

Expected behavior
The NPC should react like it doesnt know you since it is a new character.

Versions and configuration(please complete the following information):

• OS: Windows 10
• Game Version 0.C-33136-g79d9903
• Graphics version: Tiles
• Mods loaded: Not important

Additional context
To get to see this easier, choose the Prison Break scenario with spawning npc, so you can find him more easy.

[mlangsdorf]

NPCs and monsters pretty much have a boolean "friendly" attitude for all players. It should really be a faction check in both cases, and each player should have their own faction.

[Night-Pryanik]

I think this should be closed after #29182?

[kevingranade]

New player in same world after death of existing player will not suffer this problem, but a concurrent game will.

[mlangsdorf]

We can try making the your_followers a numbered faction, but there were issues with the loading order the last time I tried this.

[I-am-Erk]

Honestly because so many NPC dialogue conditionals are stored globally, this is a problem that persists in a huge number of NPC settings and would be nearly impossible to fix for most of them. I suggest that we just add a warning when you try to make a character in a world that's been played in before, whether the player is dead or not: "Cataclysm: Dark Days Ahead is not really made for multiple runs in a single world. You may experience some bugs if you have already played extensively in this world. Press "esc" to go back and make a new world for your new character, or any key to continue anyway."

We should also make sure that Play Now options try to select "pristine" worlds if there are any available.

[ElonSatoshi]

And also make the default world behavior be to delete, not keep.

If we did something like that, would that be enough to close this issue?? Or at least to move it out of the 0.E milestone?

[I-am-Erk]

I don't mind that solution, actually. Then the warning could go in the options menu.

[ghost]

Do we now consider this "fixed" for the purposes of 0.E ?

[I-am-Erk]

Yeah, don't know why it didn't auto close when the pr merged

[kevingranade]

This issue has been mentioned on Cataclysm: Dark Days Ahead. There might be relevant details there:

https://discourse.cataclysmdda.org/t/followers-retained-by-new-character/25024/2

[kevingranade]

This issue has been mentioned on Cataclysm: Dark Days Ahead. There might be relevant details there:

https://discourse.cataclysmdda.org/t/two-characters-three-horses-one-crazy-world/25085/2