Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Petrified eye mine finale not properly triggering #13310

Closed
Rainboww opened this issue Aug 16, 2015 · 5 comments · Fixed by #51167
Closed

Petrified eye mine finale not properly triggering #13310

Rainboww opened this issue Aug 16, 2015 · 5 comments · Fixed by #51167
Labels
<Bug> This needs to be fixed <Exploit> Unintended interactions or behavior, usually breaking how the game is balanced (S2 - Confirmed) Bug that's been confirmed to exist

Comments

@Rainboww
Copy link

Windows, tiles, Latest experimental (3577), the petrified eye mine finale doesn't "trigger" (summon wyrms, tremors, screaming) until you examine the pedestal a second time after succesfully removing the eye, making it trivial to leave the mine with it as long as you don't go out of your way to trigger it.

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@drbig drbig added <Bug> This needs to be fixed (S1 - Need confirmation) Report waiting on confirmation of reproducibility labels Aug 17, 2015
@illi-kun illi-kun removed the (S1 - Need confirmation) Report waiting on confirmation of reproducibility label Oct 7, 2016
@Leland Leland added Other Things that can't be classified anywhere else (S2 - Confirmed) Bug that's been confirmed to exist labels May 24, 2017
@ZhilkinSerg ZhilkinSerg self-assigned this Apr 3, 2018
@int-ua
Copy link
Contributor

int-ua commented Jan 26, 2021

Is that finale still in the game? I've just teleported to about a dozen of mines and all of them were spiral caverns. Maybe that's another issue.

@anothersimulacrum
Copy link
Member

Spiral caverns seem to always spawn under mines, no matter if they are accesible or not. Are you teleporting to the final M room, or to the spiral caverns and not looking up?

@int-ua
Copy link
Contributor

int-ua commented Jan 26, 2021

Still relevant on build 11388.

@int-ua int-ua added <Exploit> Unintended interactions or behavior, usually breaking how the game is balanced and removed Other Things that can't be classified anywhere else labels Jan 26, 2021
@actual-nh
Copy link
Contributor

Ping: @Night-Pryanik?

@Night-Pryanik
Copy link
Contributor

The bug occurs because of the following.

  1. Game spawns "wyrms" mine finale room.
  2. Game spawns a pedestal in the center of that room.
  3. Game places petrified eye on the pedestal.
  4. Player examines the pedestal. Code says that iexamine function should do nothing if there's any item on the pedestal:
if( !here.i_at( examp ).empty() ) {
    none( p, examp );
    return;
}

This includes petrified eye! So nothing happens at all.
5.Player safely takes the eye from the pedestal.
6. Player examines pedestal once again. There's no items on it, so "wyrms" event triggers.

Also player could completely bypass the whole event by using g to get the eye from the pedestal (or use AIM) rather than examine it because event triggers only on examining. To this fix the bug we somehow need to forbid player from taking off petrified eye by any means except by examining it.

To fix the bug in the OP we probably need to remove the check for emptiness of the pedestal or rework it somehow so it should behave properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bug> This needs to be fixed <Exploit> Unintended interactions or behavior, usually breaking how the game is balanced (S2 - Confirmed) Bug that's been confirmed to exist
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants