Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Directionless rules are expanded unnecessarily #72

Open
david-pfx opened this issue Nov 2, 2023 · 2 comments
Open

Directionless rules are expanded unnecessarily #72

david-pfx opened this issue Nov 2, 2023 · 2 comments
Labels
code Improve the code without changing functionality debugging features to help designers understand the engine's behavior duplicate This issue or pull request already exists expansion any expansion mechanism

Comments

@david-pfx
Copy link

Multiple rules are generated incorrectly for directionless rules.
From tubetransport:
[ wasMoved:dirs ] -> [ ]
generates the following:

  (1115) UP [ wasmoved:dirs ] -> [ ]
+ (1115) DOWN [ wasmoved:dirs ] -> [ ]
+ (1115) LEFT [ wasmoved:dirs ] -> [ ]
+ (1115) RIGHT [ wasmoved:dirs ] -> [ ]

Only one rule is required for a directionless rule. There is code in vanilla PS to detect and implement this.

@ClementSparrow
Copy link
Owner

I think it's a duplicate of #43, assuming that dirs is a shortcut for directions.

@ClementSparrow ClementSparrow added duplicate This issue or pull request already exists code Improve the code without changing functionality expansion any expansion mechanism debugging features to help designers understand the engine's behavior labels Nov 2, 2023
@david-pfx
Copy link
Author

It's not a duplicate, but it is obviously related. The point is that there is a category of non-directional rules, and they never need to be expanded across the multiple rule directions. See the PS code for details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code Improve the code without changing functionality debugging features to help designers understand the engine's behavior duplicate This issue or pull request already exists expansion any expansion mechanism
Projects
None yet
Development

No branches or pull requests

2 participants