-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Depth and Pose on Image with Black Borders #24
Comments
I think it will pose some problems because with warping you will compare image parts with black areas. The optimizer will try to avoid it to minimize photometric error. To my mind, your best solution is to weight the photometric error for each pixel. If you know exactly the pixels to dismiss, just multiply these photometric loss values by 0 You can find an example of how I did the same thing with out of bound warped pixels in |
Thank you for your answer! :) |
Hi, @ClementPinard |
Normally it should not be a problem. At first, pose values are very low, so warping is very close to the identity function, which makes the gradient meaningful. So discarding it from the loss value is just a way to have a more meaningful loss since you only deal with valid comparisons. This makes sense at the end of the training, where half of warping is zooming out to warp, with obvious out of bound pixels in the boundaries of the target image. |
What scenario are you using it on ? A known problem is when translation is not enough, then the depth has very little influence on the warping since the parallax is low. You can try the |
Thank you for your prompt reply. I think you are right and I have fixed my problem. The divergence in my work is just because of a stupid typo. |
Hi! I already posted about this on the original tensorflow implementation, but i would also like to know your opinion on the matter :)
Do you think that the black borders on an image like the one bellow would affect the training and the predicitons of depth/pose?
The text was updated successfully, but these errors were encountered: