Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos again #900

Merged
merged 1 commit into from
Feb 22, 2024
Merged

Fix typos again #900

merged 1 commit into from
Feb 22, 2024

Conversation

kianmeng
Copy link
Contributor

@kianmeng kianmeng commented Feb 19, 2024

Found via codespell -H

Chore that needs to be done:

  • Add newsfragment pipenv run towncrier create [issue_number].[type].rst

Types are defined in the pyproject.toml, issue_numer either from issue tracker or the Pull request number

@fizyk
Copy link
Member

fizyk commented Feb 20, 2024

newsfragment is missing

@kianmeng
Copy link
Contributor Author

@fizyk What is the issue number here?

@fizyk
Copy link
Member

fizyk commented Feb 20, 2024

Same as pr number :)

@kianmeng
Copy link
Contributor Author

@fizyk Done.

@codecov-commenter
Copy link

codecov-commenter commented Feb 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (22944af) 95.26% compared to head (1284f4c) 95.32%.
Report is 27 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #900      +/-   ##
==========================================
+ Coverage   95.26%   95.32%   +0.06%     
==========================================
  Files          13       13              
  Lines         401      428      +27     
==========================================
+ Hits          382      408      +26     
- Misses         19       20       +1     
Flag Coverage Δ
unittests 95.32% <ø> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

pytest_postgresql/config.py Outdated Show resolved Hide resolved
Found via `codespell -H`
@kianmeng kianmeng requested a review from fizyk February 22, 2024 17:38
@fizyk fizyk merged commit 5d122c4 into ClearcodeHQ:main Feb 22, 2024
49 checks passed
@fizyk
Copy link
Member

fizyk commented Feb 22, 2024

Thank you @kianmeng

@kianmeng
Copy link
Contributor Author

🥳 🥳 🥳 🥳 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants