-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
In case of too much output OutputExecutor hangs #98
Comments
Seems related to #74. I think keeping stdout as parent process's stdout would be best (e.g. for logging output from processes in CI tests), but it would be an incompatible API change breaking |
So maybe we should make it an option:
|
Raise an exception from |
Can we make the whole output redirection non-default? It's useful only when explicitly accessing the captured output, while I need usual logging of the stdout (to my process's stdout, or captured by pytest) if any process invocation fails (e.g. when running a Java process that logs useful info on stdout). It could be easily split into a mixin. Currently I need to comment out stdout redirection when getting any error from test fixtures using Mirakuru. |
I happens when subprocess produces large amounts of output.
https://thraxil.org/users/anders/posts/2008/03/13/Subprocess-Hanging-PIPE-is-your-enemy/
Mirakuru could use real files instead of PIPE or make it an option.
The text was updated successfully, but these errors were encountered: