Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tinkers' Construct support #37

Merged
merged 32 commits into from
Mar 24, 2023
Merged

Tinkers' Construct support #37

merged 32 commits into from
Mar 24, 2023

Conversation

Testure
Copy link
Contributor

@Testure Testure commented Mar 6, 2023

Adds support for:

  • Drying rack
  • Casting table
  • Casting basin
  • Smeltery melting (including entity melting)
  • Smeltery alloying
  • Creation of material traits
  • Creation and removal of materials
  • Tinkers Complement's high oven
  • Tinkers Complement's melter
  • Construct's Armory
  • Bracket handlers for materials and traits

Construct's Armory armor can be added with the same material builder as tools.
Armor specific traits can be created by using the mods.tconstruct.Armory package which is only initialized when Construct's Armory is loaded.

Things that should be reviewed:

  • Adding materials/traits requires a custom loader that runs during FMLPreInitialization.
  • Initializing the traits of a material has to be done during FMLInitialization.
  • A temporary fix for an issue causing Loader.instance().activeModContainer() to return null has been implemented into GroovyScriptSandbox. The additional effects of this (if any) should be investigated.
  • Events for Tinkers support were added in the GroovyScript mod class. I suspect it would be better to move them elsewhere.
  • Have yet to test this in a production environment.

@Testure Testure requested a review from brachy84 March 7, 2023 20:16
Copy link
Member

@brachy84 brachy84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly fine. Tell me when you tested everything and ill merge

@brachy84 brachy84 merged commit 9f3d711 into CleanroomMC:master Mar 24, 2023
@Testure Testure deleted the tinkers branch June 28, 2023 08:44
@WaitingIdly WaitingIdly added the mod compat Relating to compatability with a mod or features of a mod label Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mod compat Relating to compatability with a mod or features of a mod
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants