Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More defaultValues for Object Mappers #249

Merged
merged 3 commits into from
Oct 4, 2024
Merged

More defaultValues for Object Mappers #249

merged 3 commits into from
Oct 4, 2024

Conversation

WaitingIdly
Copy link
Collaborator

changes in this PR:

  • add more default values to Object Mappers, specifically Thermal Expansion compactorMode, Applied Energistics 2 tunnel, and Vanilla block, blockstate, creativeTab, textformat, and nbt.
  • convert Thermal Expansion compactorMode Object Mapper to use the GroovyContainer<?> argument passed in, as all other mods do.

@WaitingIdly WaitingIdly added the enhancement New feature or request label Oct 4, 2024
@brachy84 brachy84 merged commit 345e60f into CleanroomMC:master Oct 4, 2024
@WaitingIdly WaitingIdly deleted the more-default-value-object-mapper branch October 4, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brachy84 brachy84 brachy84 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WaitingIdly @brachy84