Server side rendering

[Rikuoja]

As Riku, I want the server side rendering to work on the server, not just in development. As end user, I want to share hearings so that picture and other data are available in the facebook share.

[akx]

If it works in development, the only difference can only be in deployment and configuration. Is the serverRendering configuration option enabled in production?

[vikoivun]

Indeed it was. It created an odd half created page, with parts missing. Ghastly, really. I'll pull up a test instance to see how it goes these days.

[akx]

Very sporky. If you get it to half-break again, care to paste the HTML as received from the server? I suspect some data fetches fail, or don't have the proper guarantees (see below) set.

kerrokantasi-ui/src/views/QuestionView.js

Lines 15 to 43 in 496ed86

	/**
	* Return a promise that will, as it fulfills, have added requisite
	* data for the HearingView view into the dispatch's associated store.
	*
	* @param dispatch Redux Dispatch function
	* @param getState Redux state getter
	* @param location Router location
	* @param params Router params
	* @return {Promise} Data fetching promise
	*/
	static fetchData(dispatch, getState, location, params) {
	return Promise.all([
	dispatch(fetchHearing(params.hearingSlug, location.query.preview)),
	]);
	}
	/**
	* Return truthy if the view can be rendered fully with the data currently
	* acquirable by `getState()`.
	*
	* @param getState State getter
	* @param location Router location
	* @param params Router params
	* @return {boolean} Renderable?
	*/
	static canRenderFully(getState) {
	const {state, data} = (getState().hearing || {state: 'initial'});
	return (state === 'done' && data);
	}

[akx]

This seems to tie into #410. An executive decision should probably be made about how to tackle SSR. It shouldn't be impossible to use a compiled Webpack bundle as a server-side renderer either, mind...

[Rikuoja]

There's no need for this atm apart from the metadata tags, which already has issue #317 . Shouldn't need whole SSR to do that.