Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UHF-7126: Allow non-html values to be processed, UHF-7193: fixed radioactivity #43

Merged
merged 10 commits into from
Oct 25, 2022
Merged

UHF-7126: Allow non-html values to be processed, UHF-7193: fixed radioactivity #43

merged 10 commits into from
Oct 25, 2022

Conversation

tuutti
Copy link
Member

@tuutti tuutti commented Oct 19, 2022 •
edited
Loading

To test this, run:

  • composer require drupal/helfi_proxy:dev-UHF-7126
  • drush cr

Make sure etusivu calls radioactivity emit path with language prefix:
image

@tuutti tuutti marked this pull request as draft October 19, 2022 05:43
@codecov-commenter
Copy link

codecov-commenter commented Oct 19, 2022 •
edited
Loading

Codecov Report

Merging #43 (a71fa32) into main (be69a56) will increase coverage by 4.73%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main      #43      +/-   ##
============================================
+ Coverage     68.59%   73.33%   +4.73%     
+ Complexity      135       15     -120     
============================================
  Files            18        2      -16     
  Lines           328       45     -283     
============================================
- Hits            225       33     -192     
+ Misses          103       12      -91
Impacted Files Coverage Δ
...src/EventSubscriber/RedirectResponseSubscriber.php
modules/contrib/helfi_proxy/src/Form/PurgeForm.php
...ules/contrib/helfi_proxy/src/Selector/Selector.php
modules/contrib/helfi_proxy/src/ProxyManager.php
...i_proxy/src/HttpMiddleware/AssetHttpMiddleware.php
...ventSubscriber/TunnistamoRedirectUrlSubscriber.php
...s/contrib/helfi_proxy/src/SessionConfiguration.php
...oxy/src/EventSubscriber/CorsResponseSubscriber.php
...proxy/src/Selector/MultiValueAttributeSelector.php
modules/contrib/helfi_proxy/src/ProxyTrait.php
... and 10 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@tuutti tuutti changed the title UHF-7126: Refactored ProxyManager::processHtml to allow non-html valu… UHF-7126: Allow non-html values to be processed Oct 19, 2022
@tuutti tuutti marked this pull request as ready for review October 20, 2022 06:43
@tuutti tuutti changed the title UHF-7126: Allow non-html values to be processed UHF-7126: Allow non-html values to be processed, UHF-7193: fixed radioac Oct 20, 2022
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 30 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@tuutti tuutti changed the title UHF-7126: Allow non-html values to be processed, UHF-7193: fixed radioac UHF-7126: Allow non-html values to be processed, UHF-7193: fixed radioactivity Oct 20, 2022
jeremysteerio
jeremysteerio approved these changes Oct 25, 2022
View reviewed changes
Copy link

@jeremysteerio jeremysteerio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as intended 👍

@tuutti tuutti merged commit e75e953 into main Oct 25, 2022
@tuutti tuutti deleted the UHF-7126 branch October 25, 2022 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeremysteerio jeremysteerio jeremysteerio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tuutti @codecov-commenter @jeremysteerio