Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Revert "UHF-8526: Use PubSub to invalidate caches"" #44

Merged
merged 5 commits into from
Oct 6, 2023

Conversation

tuutti
Copy link
Member

@tuutti tuutti commented Sep 26, 2023

Reverts #43

@codecov-commenter
Copy link

codecov-commenter commented Sep 26, 2023

Codecov Report

Merging #44 (9a3ba48) into main (d625038) will increase coverage by 0.54%.
The diff coverage is 100.00%.

❗ Current head 9a3ba48 differs from pull request most recent head 5bba875. Consider uploading reports for the commit 5bba875 to get more accurate results

@@             Coverage Diff              @@
##               main      #44      +/-   ##
============================================
+ Coverage     70.29%   70.83%   +0.54%     
+ Complexity      178      177       -1     
============================================
  Files            20       20              
  Lines           670      679       +9     
============================================
+ Hits            471      481      +10     
+ Misses          199      198       -1     
Files Coverage Δ
src/ApiManager.php 100.00% <100.00%> (ø)
src/ExternalMenuTreeBuilder.php 100.00% <100.00%> (+1.40%) ⬆️
src/MainMenuManager.php 100.00% <ø> (ø)
src/Menu/MenuTreeBuilder.php 96.15% <ø> (ø)
src/Plugin/QueueWorker/MenuQueue.php 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@teroelonen teroelonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good 🦖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants