UHF-10466: Prevent suunte js aggregation

[rpnykanen]

UHF-10466

Drupal aggregation prevented suunte-chat initialization for some reason.

What was done

Prevent suunte-script aggregation

How to install

• Make sure your instance is up and running on latest dev branch.
  • git pull origin dev
  • make fresh
• Update the Helfi Platform config
  • composer require drupal/helfi_platform_config:dev-UHF-10466
• Run make drush-updb drush-cr

How to test

• Make sure the JS aggregation is enabled
  • (Go check local.settings.php and comment the js preprocess if not commented)
• Go to hammashoita-page as anonymous user FINNISH language
• Hammashoito-chat button should be visible
• Open inspector, check network tab and filter by JS,
  • Check that the genesys_suunte.js is listed in the loaded JS files list (which means not aggregated)

Continuous documentation

• This feature has been documented/the documentation has been updated
• This change doesn't require updates to the documentation

[juho-lehmonen]

Getting this error when trying to load the preprocessed JS file. Also, genesys_suunte.js isn't loaded individually. The Chat button shows up but doesn't work.

The website encountered an unexpected error. Try again later.

Exception: Only file JavaScript assets with preprocessing enabled can be optimized. in Drupal\Core\Asset\JsOptimizer->optimize() (line 34 of core/lib/Drupal/Core/Asset/JsOptimizer.php).

Drupal\Core\Asset\JsCollectionOptimizerLazy->optimizeGroup() (Line: 184)
Drupal\system\Controller\AssetControllerBase->deliver()
call_user_func_array() (Line: 123)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 638)
Drupal\Core\Render\Renderer->executeInRenderContext() (Line: 121)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext() (Line: 97)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 181)
Symfony\Component\HttpKernel\HttpKernel->handleRaw() (Line: 76)
Symfony\Component\HttpKernel\HttpKernel->handle() (Line: 53)
Drupal\Core\StackMiddleware\Session->handle() (Line: 48)
Drupal\Core\StackMiddleware\KernelPreHandle->handle() (Line: 28)
Drupal\Core\StackMiddleware\ContentLength->handle() (Line: 191)
Drupal\page_cache\StackMiddleware\PageCache->fetch() (Line: 128)
Drupal\page_cache\StackMiddleware\PageCache->lookup() (Line: 82)
Drupal\page_cache\StackMiddleware\PageCache->handle() (Line: 48)
Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle() (Line: 51)
Drupal\Core\StackMiddleware\NegotiationMiddleware->handle() (Line: 36)
Drupal\Core\StackMiddleware\AjaxPageState->handle() (Line: 51)
Drupal\Core\StackMiddleware\StackedHttpKernel->handle() (Line: 741)
Drupal\Core\DrupalKernel->handle() (Line: 19)

Also getting this JS error in the console on the Hammashoito page, but this also happens on the current platform config module version, so not sure if it's related:

Uncaught TypeError: can't access property "get", cookies is undefined
 getCookieStatus https://helfi-sote.docker.so/terveys-assets/modules/contrib/eu_cookie_compliance/js/eu_cookie_compliance.js?v=10.3.2:744

The cookies JS error is also triggered every time you try to click the chat button.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud