Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-9741: News archive refresh #785

Merged
merged 3 commits into from
Jul 19, 2024
Merged

UHF-9741: News archive refresh #785

merged 3 commits into from
Jul 19, 2024

Conversation

teroelonen
Copy link
Contributor

@teroelonen teroelonen commented Jul 9, 2024

UHF-9741

What was done

  • Modified Hero block functionality that gives the block has-first-gray-bg-block class so that it can be extended based on instance needs without duplicating code.

How to install

How to test

Continuous documentation

  • This feature has been documented/the documentation has been updated (development.md)
  • This change doesn't require updates to the documentation

Other PRs

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 15.18%. Comparing base (9ebb3f1) to head (2af2fc6).
Report is 85 commits behind head on main.

Files Patch % Lines
src/Plugin/Block/HeroBlock.php 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #785      +/-   ##
============================================
- Coverage     15.28%   15.18%   -0.10%     
- Complexity      258      259       +1     
============================================
  Files            31       31              
  Lines           962      981      +19     
============================================
+ Hits            147      149       +2     
- Misses          815      832      +17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Copy link
Contributor

@khalima khalima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know I helped with this, but still... Good job! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants