Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-9493: Drupal 10.3 compatibility #780

Merged
merged 12 commits into from
Jun 26, 2024
Merged

UHF-9493: Drupal 10.3 compatibility #780

merged 12 commits into from
Jun 26, 2024

Conversation

khalima
Copy link
Contributor

@khalima khalima commented Jun 24, 2024

Drupal 10.3 update

❗ Note that the tests will fail until the Helfi Drupal Platform PR City-of-Helsinki/drupal-helfi-platform#252 is merged ❗

What was done

  • Re-rolled and applied patches for "Strip whitespaces from twig debug comments" and "Process translation config files for custom modules"

How to install

  • Make sure your instance is up and running on latest dev branch.
    • git pull origin dev
    • make fresh
  • Update the Helfi Platform config and proxy
    • composer require drupal/helfi_platform_config:dev-UHF-9493 drupal/helfi_proxy:dev-UHF-9493 -W
    • If none of the patches actually gets installed, you can run rm -rf public/core && composer i to make sure the patches gets installed correctly.
  • Run make drush-updb drush-cr

How to test

  • Check that the Drupal 10.3 gets installed correctly 😇 . You can check the major D10.3 changes from this blog post
    • There was a change to custom module configuration translations and the patch was re-rolled. If the patch didn't work, none of our update hooks would've worked during drush updb
    • Another update was added to twig.engine debug messages and the patch needed to be re-rolled. When the local.services.yml debug: true is set, you should still see the debug messages in the markup like before.
  • Check that code follows our standards

Other PRs

Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants