Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-9932: Additional checks to prevent notices/errors #739

Merged
merged 1 commit into from
Apr 9, 2024
Merged

Conversation

rpnykanen
Copy link
Contributor

@rpnykanen rpnykanen commented Apr 9, 2024

UHF-9932

Prevent RTL languages showing up as LTR in ckeditor by overriding the language given to ckeditor.

How to reproduce:

  • Setup etusivu-instance
  • Make sure your user's ui language is either und or any LTR-language
  • Go edit any existing arabic content

Ckeditor should show the arabic as LTR

How to install

  • Make sure your instance is up and running on latest dev branch.
    • git pull origin dev
    • make fresh
  • Update the Helfi Platform config
    • composer require drupal/helfi_platform_config:dev-UHF-9932
  • Run make drush-updb drush-cr

How to test

  • Go and edit the arabic content
  • See that the content shows up like RTL-language
  • See that the editor works as it is expected to work with RLT-language
  • See that the page looks OK after saving

…ing happens. Also make sure the revering is not done when language is ltr
Copy link

sonarqubecloud bot commented Apr 9, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants