Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-9496: Add option to place phone number in "Other contact details" accordion. #730

Merged
merged 3 commits into from
Apr 4, 2024

Conversation

hyrsky
Copy link
Contributor

@hyrsky hyrsky commented Apr 4, 2024

UHF-9496

What was done

  • Add option to place phone number in "Other contact details" accordion.

How to install

  • Make sure your instance is up and running on latest dev branch.
    • git pull origin dev
    • make fresh
  • Update the Helfi Platform config & HDBT
    • composer require drupal/helfi_platform_config:dev-UHF-9496-phone-number-option
    • composer require drupal/hdbt:dev-UHF-9496-phone-number-option
  • Run make drush-updb drush-cr

How to test

Continuous documentation

  • This feature has been documented/the documentation has been updated
  • This change doesn't require updates to the documentation

Translations

  • Translations have been added to .po -files and included in this PR

Other PRs

@hyrsky hyrsky force-pushed the UHF-9496-phone-number-option branch from 1318339 to 3ce3c5c Compare April 4, 2024 05:55
Copy link

sonarqubecloud bot commented Apr 4, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 14.53%. Comparing base (c9d0b26) to head (66b5164).

❗ Current head 66b5164 differs from pull request most recent head 3ce3c5c. Consider uploading reports for the commit 3ce3c5c to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #730   +/-   ##
=========================================
  Coverage     14.53%   14.53%           
  Complexity      256      256           
=========================================
  Files            30       30           
  Lines           977      977           
=========================================
  Hits            142      142           
  Misses          835      835           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Arkkimaagi Arkkimaagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, looks and works as it should! 🌷

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants