Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uhf 9767 preview revision form fix #711

Merged
merged 2 commits into from
Mar 20, 2024

Conversation

rpnykanen
Copy link
Contributor

@rpnykanen rpnykanen commented Mar 12, 2024

UHF-9767

Revision overview form is missing current revision.
Check this issue https://www.drupal.org/project/drupal/issues/3390329

What was done

Force the first revision to be visible.

How to reproduce bug before you apply the fix:

Create new content, add a field, save
Create a translation for the content and save
Add a new paragraph to the translation and save as new revision
Go check the original language revision overview form. You should be missing "current revision" row from the table

How to install

  • Make sure your instance is up and running on latest dev branch.
    • git pull origin dev
    • make fresh
  • Update the Helfi Platform config
    • composer require drupal/helfi_platform_config:dev-UHF-9767_preview_revision_form_fix
  • Run composer install to apply the patch
  • Run make drush-updb drush-cr

How to test

Follow the reproduction steps. Now all translations should have the current revision visible always.
Try rollbacking revisions and saving and rollbacking again and see that it always shows correct revision as first (for all languages)

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 13.01%. Comparing base (cd47f23) to head (70a6831).

❗ Current head 70a6831 differs from pull request most recent head 107d84d. Consider uploading reports for the commit 107d84d to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #711   +/-   ##
=========================================
  Coverage     13.01%   13.01%           
  Complexity      242      242           
=========================================
  Files            28       28           
  Lines           945      945           
=========================================
  Hits            123      123           
  Misses          822      822           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hyrsky hyrsky self-requested a review March 12, 2024 10:44
Copy link
Contributor

@hyrsky hyrsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to reproduce the issue and this patch fixed it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants