-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UHF-8988 user inquiry popup #693
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #693 +/- ##
=========================================
Coverage 13.07% 13.07%
Complexity 242 242
=========================================
Files 28 28
Lines 941 941
=========================================
Hits 123 123
Misses 818 818 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works but there is a PHPCS issue.
Quality Gate passedIssues Measures |
UHF-8988
Adds and configures chat-leijuke with käyttäjäkysely-popup
What was done
How to install
git pull origin dev
make fresh
composer require drupal/helfi_platform_config:dev-UHF-8988
make drush-updb drush-cr
How to test
Log in as admin and go to /admin/structure/block
Log out, since this only works for unauthenticated user
(the debug feature does not work incognito)
Go to any content page and accept all cookies
After page reload the popup-script should not be loaded (search for digitalfeedback)
The next steps must be done quite quickly:
There is a commented code snippet in the leijuke-js file line 116. Run this code snippet in browser inspector to activate the popup locally for 1 minute:
localStorage.setItem('user_inquiry_debug',
{"start": "${new Date((Date.now()-60000)).toString()}", "end": "${new Date((Date.now()+60000))}"}
);