Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-9915: Change News card teaser styling #994

Merged
merged 3 commits into from
May 29, 2024
Merged

UHF-9915: Change News card teaser styling #994

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
328bf6c
change card teaser styling
j-mys May 27, 2024
64b9db1
UHF-9915: Refactor styles related to news card-teasers and medium-tea…
teroelonen May 28, 2024
ef63209
UHF-9915: Merge branch 'main' of https://github.com/City-of-Helsinki/…
teroelonen May 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dist/css/styles.min.css
View file
Open in desktop

Large diffs are not rendered by default.

60 changes: 31 additions & 29 deletions src/scss/06_components/pages/_news-page.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
padding-top: 0;
}

:not(.latest-news-list) > .news-listing__item {
:not(.latest-news-list, .component--top-news .news-listing) > .news-listing__item {
list-style: none;
margin-top: $spacing-and-half;
padding-left: 0; // Remove card paddings from news listing
Expand Down Expand Up @@ -75,6 +75,19 @@
}

// News listings using medium teasers.
.news-listing--medium-teasers {
list-style: none;

.news-listing__item + .news-listing__item {
margin-top: $spacing-and-half;

@include breakpoint($breakpoint-m) {
margin-top: 0;
}
}
}

// Latest news block variant.
.news-listing--latest-medium-teasers {
padding-inline-start: 0; // User agent stylesheet override

Expand Down Expand Up @@ -201,34 +214,28 @@
}

.news-listing--card-teasers {
padding-inline-start: 0; // User agent stylesheet override
grid-gap: 0;
display: grid;
list-style: none;
padding-left: 0;

@include breakpoint($breakpoint-m) {
display: flex;
flex-direction: row;
flex-wrap: wrap;
margin-inline-end: -#{$spacing-and-half};
grid-column-gap: $spacing-and-half;
grid-template-columns: repeat(3, 1fr);
}

.news-listing__item {
@include breakpoint($breakpoint-m) {
width: 50%;
}
.news-listing__item + .news-listing__item {
margin-top: $spacing-double;

@include breakpoint($breakpoint-l) {
width: 25%;
@include breakpoint($breakpoint-m) {
margin-top: 0;
}
}

.news-listing__card-teaser {
height: 100%;
}
}

.news-listing__card-teaser {
border-bottom: 1px solid var(--color-black-5);
display: flex;
padding-bottom: $spacing;
height: 100%;
position: relative;

&:hover .hel-icon--arrow-right {
Expand All @@ -240,21 +247,12 @@
}

@include breakpoint($breakpoint-m) {
border: 1px solid var(--color-black);
flex-direction: column;
margin-inline-end: $spacing-and-half;
padding-bottom: 0;
}

.news-listing__title {
@include font('h5');

// The card style changes already on breakpoint-m so we need to switch to larger
// h5-style earlier.
@include breakpoint($breakpoint-m) {
font-size: remify(20px);
line-height: 30 / 20;
}
@include font('h4');
}

.news-listing__img {
Expand Down Expand Up @@ -284,11 +282,15 @@
width: 60%;

@include breakpoint($breakpoint-m) {
padding: $spacing;
padding: $spacing 0 0 0;
width: unset;
}
}

.news-listing__link {
text-decoration: underline;
}

.news-listing__title,
.news-listing__datetime {
margin-bottom: $spacing-half;
Expand Down
2 changes: 0 additions & 2 deletions templates/module/helfi-news-item/node--news-item--card-teaser.html.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,5 @@
{{ published_at|format_date('publication_date_format') }}
</time>
{% endif %}

{% include "@hdbt/misc/icon.twig" with {icon: 'arrow-right'} only %}
</div>
</div>