Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-X Visual regression test content #975

Merged
merged 3 commits into from
Apr 25, 2024

Conversation

khalima
Copy link
Contributor

@khalima khalima commented Apr 23, 2024

What was done

  • Added hel.fi brand colors to visual regression tests.

How to install

  • Build a new test-site
    • composer create-project City-of-Helsinki/drupal-helfi-platform:dev-main test --no-interaction --repository https://repository.drupal.hel.ninja/
  • Update the Helfi Platform config
    • composer require drupal/helfi_platform_config:dev-UHF-X_helfi_test_content_update
  • Update the HDBT theme
    • composer require drupal/hdbt:dev-UHF-X_helfi_test_content_update
  • Get the site up and running
    • make new
  • Run make shell
    • In shell run drush en -y helfi_test_content

How to test

  • Run nvm use; npm i; npm run full-reference.
    • This will take a while.. It'll create the reference images.
  • Run open backstop/full/html_report/index.html in the theme folder.
    • This will open the report page to your browser.
    • Scroll down to full_DC_Suomenlinna_0_document_0_Breakpoint_XS.png and check that all helfi brand colors are included in the latter screenshots
  • Check that code follows our standards

@khalima khalima marked this pull request as ready for review April 23, 2024 11:50
Copy link

⚠️ Visual regression found! Please check if this change is wanted or accidental. You can check the output here: https://city-of-helsinki.github.io/drupal-hdbt/pull/975/html_report/

Copy link
Contributor

@teroelonen teroelonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't get this to create the backstop/full/html_report/index.html file.

Copy link
Contributor

@teroelonen teroelonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This worked very nicely after running the npm run full-test 🦖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants