Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-9956: Testing evaluate rule #973

Merged
merged 1 commit into from
Apr 22, 2024
Merged

UHF-9956: Testing evaluate rule #973

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions .github/workflows/visual.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,11 +135,11 @@ jobs:

- name: Generate new reference images
working-directory: ${{ env.THEME_FOLDER }}
if: steps.evaluate-reference-images.outputs.generate-references == true
if: steps.evaluate-reference-images.outputs.generate-references == 'true'
run: npm run full-reference

- uses: actions/upload-artifact@v4
if: steps.evaluate-reference-images.outputs.generate-references == true
if: steps.evaluate-reference-images.outputs.generate-references == 'true'
with:
name: bitmaps
path: ${{ env.THEME_FOLDER }}/backstop/full/bitmaps_reference
Expand All @@ -150,7 +150,7 @@ jobs:
working-directory: ${{ env.THEME_FOLDER }}
id: run-tests
# Skip tests if we generated reference images since the tests should never fail.
if: steps.evaluate-reference-images.outputs.generate-references != true
if: steps.evaluate-reference-images.outputs.generate-references != 'true'
run: |
if ! npm run full-test; then
echo "result=:warning: Visual regression found! Please check if this change is wanted or accidental. " >> $GITHUB_OUTPUT
Expand All @@ -161,14 +161,14 @@ jobs:

- name: Deploy to PR preview
uses: peaceiris/actions-gh-pages@v4
if: steps.evaluate-reference-images.outputs.generate-references != true
if: steps.evaluate-reference-images.outputs.generate-references != 'true'
with:
github_token: ${{ secrets.GITHUB_TOKEN }}
publish_dir: ${{ env.THEME_FOLDER }}/backstop/full/
destination_dir: pull/${{github.event.number}}

- name: Update comment
if: steps.evaluate-reference-images.outputs.generate-references != true
if: steps.evaluate-reference-images.outputs.generate-references != 'true'
uses: thollander/actions-comment-pull-request@v2
with:
comment_tag: status
Expand Down
Loading