Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-5532: Fixes issue with 4 cards not fitting side by side on the contact card listing #911

Merged
merged 3 commits into from
Feb 27, 2024

Conversation

teroelonen
Copy link
Contributor

@teroelonen teroelonen commented Feb 27, 2024

UHF-5532

What was done

  • Fix issue with column gap not being calculated to the cards width the way it should have been to make it possible to have four cards on a same row.

How to install

  • Make sure your ELO instance is up and running on latest dev branch.
    • git pull origin dev
    • make fresh
  • Update the HDBT theme
    • composer require drupal/hdbt:dev-UHF-5532_column_gap_fixes
  • Run make drush-cr

How to test

Designers review

  • This PR does not need designers review

Copy link
Contributor

@khalima khalima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. 🚀

@teroelonen teroelonen added the recreate-reference-images Use this label to re-create reference images used by Visual regression tests label Feb 27, 2024
Copy link

⚠️ Visual regression found! Please check if this change is wanted or accidental. You can check the output here: https://city-of-helsinki.github.io/drupal-hdbt/pull/911/html_report/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
recreate-reference-images Use this label to re-create reference images used by Visual regression tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants