Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-5532: Contact card visual adjustments #910

Merged
merged 8 commits into from
Feb 26, 2024
Merged

UHF-5532: Contact card visual adjustments #910

merged 8 commits into from
Feb 26, 2024

Conversation

teroelonen
Copy link
Contributor

@teroelonen teroelonen commented Feb 21, 2024

UHF-5532

What was done

  • Changed contact card mobile layout to include the image on top instead that it would go next to the information.
  • Add some more space between social media icons and other content.
  • Hyphenate all the contact card information when needed.
  • Fix naming convention on the css classes.

How to install

  • Make sure your instance is up and running on latest dev branch.
    • git pull origin dev
    • make fresh
  • Update the HDBT theme
    • composer require drupal/hdbt:dev-UHF-5532
  • Run make drush-cr

How to test

  • Add a page with contact card listing and add contact cards with all the information that you can write on them. Add also one with just the picture and name filled.
  • Make sure the picture is always above the text even in mobile.
  • Check that there is a 16px space above and below social media information. Also there should be 16px space above description always.
  • Create another contact card listing without images. Make sure the layout works correctly and looks similar to what the production version https://www.hel.fi/fi/sosiaali-ja-terveyspalvelut/terveydenhoito/paihdepalvelut/paihdekuntoutus/paihdehuollon-jalkikuntoutus looks like.
  • Check that code follows our standards

Designers review

  • This PR has been visually reviewed by a designer (Sami Haikonen)

@teroelonen teroelonen marked this pull request as ready for review February 22, 2024 15:31
@teroelonen teroelonen added the recreate-reference-images Use this label to re-create reference images used by Visual regression tests label Feb 22, 2024
@juho-lehmonen juho-lehmonen self-requested a review February 26, 2024 08:13
Copy link

⚠️ Visual regression found! Please check if this change is wanted or accidental. You can check the output here: https://city-of-helsinki.github.io/drupal-hdbt/pull/910/html_report/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
recreate-reference-images Use this label to re-create reference images used by Visual regression tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants