Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-10252: Gin theme update #288

Merged
merged 4 commits into from
Jun 26, 2024
Merged

UHF-10252: Gin theme update #288

merged 4 commits into from
Jun 26, 2024

Conversation

khalima
Copy link
Contributor

@khalima khalima commented Jun 25, 2024

UHF-10252

What was done

  • Updated the conflict restriction for Gin theme to RC11.
  • As the "entity form actions" was updated in Gin theme to support the new D10.3 navigation, we needed to update hdbt_admin theme with similar changes.
  • Override Gin theme status label styles as the design solution doesn't work with our translations.

How to install

  • Make sure your instance is up and running on latest dev branch.
    • git pull origin dev
    • make fresh
  • Update the HDBT Admin theme
    • composer require drupal/hdbt_admin:dev-UHF-10252 -W
  • Run make drush-cr

What was changed in Gin theme between rc10 and rc11

How to test

The biggest issue with Gin RC11 was the Move form actions to sticky bar commit which broke our form action buttons completely.

  • Go through all entity forms and check that the "Published" checkbox and all other buttons next to it works as before.
    image
  • Check that code follows our standards

Other PRs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants