Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-9739 Updating news #282

Merged
merged 2 commits into from
May 20, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dist/css/styles.min.css

Large diffs are not rendered by default.

1 change: 1 addition & 0 deletions dist/js/updatingNewsAutoToggle.min.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 7 additions & 0 deletions hdbt_admin.libraries.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,13 @@ tpr-edit-form:
js:
dist/js/tprEditForm.min.js: {}

updating-news-auto-toggle:
js:
dist/js/updatingNewsAutoToggle.min.js: {}
version: 1.0
dependencies:
- core/once

debug-item-composer:
js:
dist/js/debug-item-composer.min.js: {}
Expand Down
5 changes: 5 additions & 0 deletions hdbt_admin.theme
Original file line number Diff line number Diff line change
Expand Up @@ -146,6 +146,11 @@ function hdbt_admin_form_node_form_alter(&$form, FormStateInterface $form_state)
) {
$form['menu']['content_translation_status']['#access'] = FALSE;
}

// Auto toggle updating news field group if there is content in the group.
if ($node->getType() === 'news_item') {
$form['#attached']['library'][] = 'hdbt_admin/updating-news-auto-toggle';
}
}

/**
Expand Down
6 changes: 3 additions & 3 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

28 changes: 28 additions & 0 deletions src/js/updatingNewsAutoToggle.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
/**
* @file
* Updating news field group auto toggle if there is content.
*/

(function (once) {

'use strict';

const updatingNews = once(
'updating-news-auto-toggle',
'[data-drupal-selector="edit-group-updating-news"]'
);

if (updatingNews.length === 0) {
return;
}

updatingNews.forEach(details => {
const updatingNewsContent = details.querySelector(
'table.field-news-item-updating-news-values > tbody'
);

if (updatingNewsContent) {
details.open = true;
}
});
})(once);
2 changes: 1 addition & 1 deletion src/scss/06_components/misc/_select-paragraph.scss
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ $button-border-radius: 6px;
background-color: $color-white;
height: $button-height;
min-height: $button-height;
width: 400px;
width: 450px;

.dropbutton__item {
min-height: calc(#{$button-height} - (#{$button-border-thickness} * 2));
Expand Down
1 change: 1 addition & 0 deletions src/scss/06_components/paragraphs/__index.scss
Original file line number Diff line number Diff line change
Expand Up @@ -9,4 +9,5 @@
@import 'library';
@import 'liftup-with-image';
@import 'list-of-links';
@import 'news-update';
@import 'text';
36 changes: 36 additions & 0 deletions src/scss/06_components/paragraphs/_news-update.scss
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
// Hide news item updating news paragraph label as it's obsolete in field group.
.field-news-item-updating-news-values > thead {
display: none;
}

// Hide news update paragraph field label as it's only taking extra space in UI.
.field-news-update-values > thead {
display: none;
}

// Remove extra margins, padding and borders from
// the date picker field wrapper and labels.
.hdbt-admin .field--name-field-news-update-date > fieldset {
border: 0;
margin-bottom: 0;
padding: 0;

// Unify the font-size of the date-picker field label.
.fieldset__label {
font-size: remify(16px) !important;
line-height: 1.5 !important;
padding: 0;
}

// Remove side margins from fieldset wrapper.
.fieldset__wrapper {
margin-left: 0;
margin-right: 0;
}

// Remove all margins from datetime wrapper and datetime label.
.fieldset__wrapper .form-datetime-wrapper,
.form-item.form-item--no-label {
margin: 0;
}
}