Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We should not look up user accounts by email address. #159

Closed
inghamn opened this issue Apr 30, 2018 · 0 comments
Closed

We should not look up user accounts by email address. #159

inghamn opened this issue Apr 30, 2018 · 0 comments
Milestone

Comments

@inghamn
Copy link
Member

inghamn commented Apr 30, 2018

Right now, when looking for an active user, inRoads looks in both the username and password field. One result of this, is that city employees can login with either CAS or Auth0.

However, during account deletion, we are currently only clearing out the username field. We probably want to keep the email address of people, even if they're no longer an active user. That way we can still reach out to past users, if need be.

I think the right thing to do is to only look up user accounts using the username field. For Auth0 users, the username field will be the email address they use in Auth0. If there's a downside to this, it's that user accounts will no longer be able to use either authentication system, since the usernames for city accounts are not email addresses.

@inghamn inghamn added this to the 1.2 milestone Apr 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant