Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use of "latest" and "win-latest" tags in helm charts does not follow best-practice #34

Open
technotaff-nbs opened this issue Oct 18, 2022 · 0 comments

Comments

@technotaff-nbs
Copy link

technotaff-nbs commented Oct 18, 2022

We are a large AppD customer, looking to expand our use of the cluster-agent.

Currently we have to patch our values file with replacements for "latest" and "win-latest". It is not helm-chart and/or kubernetes best-practice to use floating image versions.

References to "latest" and "win-latest" should be updated to the current release when the helm chart is released.

This was the helm chart footprint is known and tested. We test and whitelist all images which are pulled to our clusters, use of non version-aligned tags breaks this pattern.

instead of

imageInfo:
  agentImage: docker.io/appdynamics/cluster-agent
  agentTag: 22.9.0
  operatorImage: docker.io/appdynamics/cluster-agent-operator
  operatorTag: 22.9.0
  imagePullPolicy: Always                               # Will be used for operator pod
  machineAgentImage: docker.io/appdynamics/machine-agent
  machineAgentTag: latest
  machineAgentWinImage: docker.io/appdynamics/machine-agent-analytics
  machineAgentWinTag: win-latest
  netVizImage: docker.io/appdynamics/machine-agent-netviz
  netvizTag: latest

it would be better to have a tested version of machineAgentTag, machineAgentWinTag and netvizTag:

imageInfo:
  agentImage: docker.io/appdynamics/cluster-agent
  agentTag: 22.9.0
  operatorImage: docker.io/appdynamics/cluster-agent-operator
  operatorTag: 22.9.0
  imagePullPolicy: Always                               # Will be used for operator pod
  machineAgentImage: docker.io/appdynamics/machine-agent
  machineAgentTag: 22.9.0
  machineAgentWinImage: docker.io/appdynamics/machine-agent-analytics
  machineAgentWinTag: 22.9.0
  netVizImage: docker.io/appdynamics/machine-agent-netviz
  netvizTag: 21.3.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant