This repository has been archived by the owner on Jul 27, 2023. It is now read-only.
Enable security for CI testing #1379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For whatever reason, I had the `--enable=false` flag passed into the security-setup script. I have a feeling this was copy-pasta.
|
Mainly for my own benefit, here is the source of the copy pasta: https://github.com/CiscoCloud/mantl/blob/db2884caad33a6f1fd42c06efb3db37afa64ab44/docker_launch.sh#L15 |
|
LGTM, merge on green (or at least when this isn't the problem) |
|
GCE passed, AWS failed on consul election, and DO has a fresh bug I haven't seen yet (not directly related here). Merging |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For whatever reason, I had the
--enable=falseflag passed into the security-setup script. I have a feeling this was copy-pasta. This will fix a whole class of Travis CI errors.