This repository has been archived by the owner on Jul 27, 2023. It is now read-only.
k8s: consistent variable names and updated samples #1371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ryane
commented
Apr 21, 2016
•
ryane
commented
- Installs cleanly on a fresh build of most recent master branch
- Upgrades cleanly from the most recent release
- Updates documentation relevant to the changes
- tested GCE but not digitalocean or openstack
- Uses consistent naming for kube* variables
- Updates digitalocean and openstack samples with Kubernetes support
|
@BrianHicks any comments on this one? |
|
LGTM |
| output "kube_worker_ips" { | ||
| value = "${join(\",\", vsphere_virtual_machine.mi-kube-worker-nodes.*.network_interface.ip_address)}" | ||
| output "kubeworker_ips" { | ||
| value = "${join(\",\", vsphere_virtual_machine.mi-kubeworker-nodes.*.network_interface.ip_address)}" |
There was a problem hiding this comment.
Should there be two of this line?
langston-barrett
force-pushed
the
fix/k8s-vars
branch
from
bf1e068 to
3358af9
Compare
|
@BrianHicks I rebased, but poorly. Could you double check my work and merge if it's ready? |
|
what did you rebase? It doesn't look like anything changed except our discussion. |
|
@BrianHicks The vsphere terraform config had changed in master, I overrode it with ryan's changes. Good, I think I did it all correctly. |
|
LGTM |
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.