Consolidate the nginx-* into a single nginx-consul container #1347
Conversation
The nginx configuration variables `do_consul_ssl`, `do_marathon_auth`, etc are written to consul and the nginx templates are configured via consul-template
|
Do not merge until the ciscocloud docker containers are updated. This PR currently uses my nginx-consul docker container. |
| --env-file=/etc/default/nginx-consul.env \ | ||
| {{ consul_nginx_image }}:{{ consul_nginx_image_tag }} | ||
|
|
||
| ExecStop=/usr/bin/docker kill nginx-consul | ||
|
|
||
| ExecReload=/usr/bin/docker kill -HUP nginx-consul |
There was a problem hiding this comment.
Why is -HUP used here? (just wondering, not a problem with your code)
There was a problem hiding this comment.
HUP is caught by the launch.sh script. When the HUP is caught, the consul-template configurations are generated and consul-template is reloaded. It could be any signal I suppose but HUP is generally used for reloading configuration.
|
This looks awesome!! |
|
👍 :) |
|
Success on a new build and an upgrade from 1.03. It is necessary to run this before upgrading: ansible-playbook -e @security.yml playbooks/upgrade-nginx-consul.yml This will be documented and incorporated into an upgrade playbook in #1392 |
The nginx configuration variables
do_consul_ssl,do_marathon_auth, etcare written to consul and the nginx templates are configured via consul-template