This repository has been archived by the owner on Jul 27, 2023. It is now read-only.
consul: turn off proxy buffering in nginx conf #1341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
diff with whitespace ignored: https://github.com/CiscoCloud/mantl/compare/fix/consul-ui-proxy-buffering?w=1 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there are many nodes and services registered, the Consul UI can break when accessed through the nginx-consul proxy. This can occur when the internal nodes endpoint (
/v1/internal/ui/nodes) returns more than 16K of data. The response is truncated and the UI fails (with an unintuitiveHTTP error code from Consul: 200 OK"error"). This turns offproxy_bufferingin the nginx config which resolves the problem.