This repository has been archived by the owner on Jul 27, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
stevendborrelli
commented
Mar 18, 2016
•
edited
Loading
edited
- Installs cleanly on a fresh build of most recent master branch
- Upgrades cleanly from the most recent release
- Updates documentation relevant to the changes
How can we tell whether or not this works (i.e. where are Mesos agent attributes visible)? |
@siddharthist you want to look at the mesos /etc/sysconfig/mesos-agent files. To test, put this in your role=worker stanza in sample.yml:
|
langston-barrett
force-pushed
the
feature/mesos-attributes
branch
from
April 7, 2016 20:20
1ad8f43
to
56852e9
Compare
rebased, will test soon. |
On a cluster upgraded from 1.0.3, looks like the config change worked:
But I lost all my Mesos agents: I was able to get my agents back by re-running current master's sample.yml. |
So you had to run it twice to make it work? The main issue here is that if an attribute changes, we need to remove the mesos meta file. |
No, I wasn't able to get this branch working. |
This setting is ignored by earlier versions of traefik, so it can be applied before traefik is upgraded.
The newest commits fix the issue. We now correctly clear out agent metadata based on the configured mesos_work_dir. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.