traefik: wait for marathon before starting (smlr) #1281
Conversation
| @@ -49,6 +58,7 @@ | |||
| - jq | |||
| - java-1.8.0-openjdk | |||
| - chrony | |||
| - smlr | |||
There was a problem hiding this comment.
I put this in the common role b/c I think we'll be able to use it in other services (marathon waiting for zookeeper, for example) in future PRs. Let me know if anyone thinks this is a bad idea.
|
LGTM! |
|
smlr packaging is actually not quite right... we are ending up with |
|
waiting on mantl/mantl-packaging#66 |
|
merged mantl/mantl-packaging#66 |
|
@sehqlr ready to test. the problem it solves is intermittent so just verify that the traefik* services are healthy in consul after a build and that there is an entry for smlr in the traefik logs. Something like: sudo journalctl -lu traefik
...
Mar 22 20:49:07 ip-10-1-2-98.ec2.internal smlr[6827]: time="2016-03-22T20:49:07Z" level=info msg=update done=true message="service available"
... |
| dest: /etc/systemd/system/traefik.service.d/marathon.conf | ||
| content: | | ||
| [Service] | ||
| ExecStartPre=-/usr/bin/smlr http {{ traefik_marathon_endpoint }}/v2/leader |
There was a problem hiding this comment.
I understand the convenience of having this inline, but most everything else we do like this is rendered as a template. Should this be as well for consistency's sake?
There was a problem hiding this comment.
switched to a template in d5635d5
|
LGTM! ⛵ |
fixes #1073