This repository has been archived by the owner on Jul 27, 2023. It is now read-only.
Openstack terraform changes: Add (optional) dns_nameservers, add volu… #1196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…me size parameters, and allow ssh_user passthrough to modules.
|
This looks like a good cleanup! Thanks @paulfrybarger-tgt. |
| @@ -14,6 +15,9 @@ variable floating_ip_pool { default = "name-of-your-floating-ip-pool" } | |||
| # Run 'nova image-list' to get your image name | |||
| variable image_name { default = "your-CentOS-7" } | |||
|
|
|||
| # DNS servers passed to Openstack subnet | |||
| variable dns_nameservers { default = "" } # comma separated list of ips, e.g. "8.8.8.8,8.8.4.4" | |||
There was a problem hiding this comment.
If this is not set, does openstack use the default values?
There was a problem hiding this comment.
Yeah, I use a compact(split(...)) to turn the empty string into an empty array, which will treat dns_nameservers as if it was not set at all.
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…me size parameters, and allow ssh_user passthrough to modules.