Skip to content
This repository has been archived by the owner on Jul 27, 2023. It is now read-only.

Change default vpc name to mantl #1479

Merged
merged 2 commits into from
Jun 7, 2016
Merged

Change default vpc name to mantl #1479

merged 2 commits into from
Jun 7, 2016

Conversation

langston-barrett
Copy link
Contributor

  • Installs cleanly on a fresh build of most recent master branch
  • Upgrades cleanly from the most recent release
  • Updates documentation relevant to the changes

@ryane
Copy link
Contributor

ryane commented May 24, 2016

can we expose the long_name var in aws.sample.tf so that it can be customized? (like we do in gce.sample.tf, for example)

@langston-barrett
Copy link
Contributor Author

@ryane Is that what you had in mind?

@ryane
Copy link
Contributor

ryane commented Jun 7, 2016

yes, that way the vpc name can be set to something other than mantl. Another question is whether we actually need a long_name and a short_name but this lgtm for now.

@ryane
Copy link
Contributor

ryane commented Jun 7, 2016

verified I could customize vpc name and aws build passed.

@ryane ryane merged commit 28d869e into master Jun 7, 2016
@ryane ryane deleted the fix/rename-vpcs branch June 7, 2016 12:53
@ryane ryane modified the milestone: 1.2 Jun 9, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants