Update SearchCondition visitor with improvements from SQL Server version #255
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following from the SQL Server part of EF Core, there has been multiple improvements and optimizations set up in the SearchConditionConvertingExpressionVisitor
Update this with those improvements
2 main ones to point out are dotnet/efcore#23711. This changes code from
<> TRUE
to= FALSE
in certain casesThere is also numerous improvements under the heading of dotnet/efcore#34001
This mostly encompasses nullable boolean expressions not returning null. Optimizations/fixes include using bitwise XOR instead of the normal
CASE
expression (or in Jet since we don't have that we use theIF
...THEN
)