-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Non-hub-transfers are not included in activity log and export statement #691
Comments
Examples: SharedWallet1 has never sent or received non-hubtransfers. They are unaffected by this bug. SharedWallet2 has received a non-hubtransfer of circles in August 5th 2022. Export after August 2022 are unaffected by this bug. Export with balance calculations at dates that date are incorrect.
SharedWallet3 has sent a non-hubtransfer of circles in August 5th 2022. Export after August 2022 are unaffected by this bug. Export with balance calculations at dates that date are incorrect.
|
Fixing this does not seem to require changes in the subgraph Example of raw response for notification from subgraph before filtering in circles-core getLatest relating to a received transitive transaction:
Note that the transactionHashes are the same Changes neededCurrently the only non-hubtransfers notifications from the subgraph that are saved are UBI-payouts (from 0 address). Further considerations:Currently the subgraph only indexes circles token transfers so b) is covered When checking a) we need to make sure that we have fetched enough notifications to be able to determine if the transfer is covered by another hubTransfer notification or not. |
Only hub-transfers are returned in
getLatest
(core method) calling the graph only for hub transfers and transfers that are ubi payout (transfers from 0-address)Non-hubtransfers can be made in other applications such as the gnosis app.
It may be confusing for users that they don't show up in the activity log. However the balance display is not affected and is correct.
When it comes to the statement export for shared wallets however, a missing transfer (non-hub-transfer) results in an incorrect balance. Balances in the exported csv file are calculated bu subtracting previous transactions. Since transactions that took place through the gnosis app are not included, it messes up the balances in the file.
This only affects wallets that have received or sent circles through non-hub transfers using e.g. gnosis app.
It affects calculations of historical balances before such transaction but not after.
The text was updated successfully, but these errors were encountered: