Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hubTransfer always returns false #108

Open
axic opened this issue Oct 19, 2020 · 0 comments
Open

hubTransfer always returns false #108

axic opened this issue Oct 19, 2020 · 0 comments

Comments

@axic
Copy link

axic commented Oct 19, 2020

We are attempting at "verifying" the contract with Solidity's SMTChecker, which already found the following.

In https://github.com/CirclesUBI/circles-contracts/blob/master/contracts/Token.sol#L170-L172 the hubTransfer function always returns false:

    function hubTransfer(
        address from, address to, uint256 amount
    ) public onlyHub returns (bool) {
        _transfer(from, to, amount);
    }

I guess this is some remnant from some old code, the _transfer function does not return an outcome. And the only place this is called is in the Hub.transferThrough function, where its outcome is not inspected.

I have not investigated further, whether the success of each transfer is validated somehow, though the validateTransferThough suggests it should be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant