Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upon trusting group, avatar implicitly trusts all the group members trustGroupMembers() #36

Closed
benjaminbollen opened this issue Nov 28, 2023 · 1 comment
Assignees

Comments

@benjaminbollen
Copy link
Member

benjaminbollen commented Nov 28, 2023

During planning discussions we had considered a user story:

  • should an avatar be able to trust indirectly all the avatars a group trusts. This could be a separate trustGroupMembers()*

*(it is open whether the members of a group are the ones a group trusts... but we can take that separate from this issue)

So after thinking briefly on this, I don't think there is a clean or gas-afforable way to include this into the architecture. To elaborate, when evaluating a path transfer, evaluating the direct edge we can do through a storage lookup; but evaluating whether there is an indirect set of edges (over one or more groups) we cannot reasonably do in the contract code upon executing a path.

So if we'd really want such a feature, we'd have to change the path data format and have the solver provide the additional evidence that such an indirect trust relation exists. That is possible, but I don't think it has merit.

I don't think it has merit, because this function is already covered by the group circle itself: people that are members of the group can mint their personal circles for group circles, and if i trust the group, and the group circles, I in effect trust the circles of that person indirectly.

PS: just making this issue to have a record of concluding why not to do this discussion point

@benjaminbollen
Copy link
Member Author

moving this to resolved

@github-project-automation github-project-automation bot moved this from 🧐Review to 💪Done in circles-contracts-v2 Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 💪Done
Development

No branches or pull requests

3 participants